-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase company logos in a better way #725
Comments
Thanks @niraj8 . To meet the web content accessibility guidelines 2.1 level AAYou'd need to:
Here's the relevant success criterion, with more guidance. To avoid people with vestibular disorders feel sickThe minimum you need to do is disable the animation within For example: .animation {
animation: <your animation as it currently is>
}
/* Remove or reduce the animation to avoid vestibular motion triggers like scaling or panning large objects. */
@media (prefers-reduced-motion) {
.animation {
animation-name: none;
}
} More details about why animations like this make people sick‘Vestibular disorder’ is like car sickness, but triggered by motions on a screen that your brain does not expect. I’m mildly sensitive to ‘vestibular disorder’ triggers. I feel mildly car sick a little bit sick after looking at this for a few seconds. But other people really do feel quite sick when seeing animations like this. Here’s another example. More guidance on
|
@jfhector Thank you for the write up! I really learned new thing about accessibility from it 😍 Also, I do feel a bit sick looking at that section as well.
I assume we still want every logo to be shown, what do you think about making it scroll horizontally instead of animating it? Or create a new page for this since there're tons of logo? |
We have a good showcase page, a selection(~10) of logos should be good on the homepage |
That sounds good to me. Perhaps something like this?
USED BY FOLKS AT
logo1 logo2 logo3 logo4 logo5 logo6 logo7 logo8 logo9 logo10 and more! TO CREATE BEAUTIFUL WEBSITES LIKE THESE And the logo will keep wrapping for responsive, it'll probably shown in one line for wide desktop. I'm also thinking, since there's a showcase page already, how about removing the "USED BY FOLKS AT" section entirely? |
I am in favour of keeping some logos on the homepage and adding a link to the showcase right below this section. |
Hey everyone,
I am available for changes and/or fixes. Just let me know what you think |
I saw your @xit4 PR but it is not ideal, the best would be to keep the animation for those who have the option activated and to put this display for those who do not have it. |
The homepage showcases logos for companies that use styled-components in their websites with an animation
There are 70+ logos that run across the screen, below is a link to the original issue by @jfhector that explains why this is not ideal.
styled-components/styled-components#3278
Let's discuss how can we better showcase these logos on the homepage
The text was updated successfully, but these errors were encountered: