Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication type should not be an explicit list #11

Closed
itineric opened this issue Feb 3, 2025 · 2 comments
Closed

Authentication type should not be an explicit list #11

itineric opened this issue Feb 3, 2025 · 2 comments

Comments

@itineric
Copy link

itineric commented Feb 3, 2025

When trying to use the tool with an authentication type defined as "access token" (or personnal access token in some tools), an error occurs :
instance value (\"accesstoken\") not found in enum (possible values: [\"oauth\",\"oauth2\",\"oauthbearertoken\",\"httpbasic\",\"httpdigest\",\"bearer\",\"Bearer\"])

But SCIM spec never declares the authentication types given as examples as explicit.

the following methodologies could be used, among others

See here: https://datatracker.ietf.org/doc/html/rfc7644#section-2

@Captain-P-Goldfish
Copy link

Also, the specification notes several values but does not forbid other values. What if authentication is done with SAML? The spec does not define a value for this but it is a perfectly legal usecase

@suvera
Copy link
Owner

suvera commented Feb 25, 2025

You are correct, currently this tool has setup some of the ENUM values and checking against that.

https://github.com/suvera/scim2-compliance-test-utility/blob/master/src/main/resources/schema/ServiceProviderConfig.schema.json#L126

"type": {
        "type": "string",
        "enum": [
            "oauth",
            "oauth2",
            "oauthbearertoken",
            "httpbasic",
            "httpdigest",
            "bearer",
            "Bearer"
        ]
},

"enum" must be removed.

Fixed! 👍 df2c862

@suvera suvera closed this as completed Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants