Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fantastic build tool && Quick question #1170

Open
multiplehats opened this issue Dec 16, 2020 · 2 comments
Open

Fantastic build tool && Quick question #1170

multiplehats opened this issue Dec 16, 2020 · 2 comments
Labels
help wanted Extra attention is needed Status: PR Welcome Type: Feature New feature or request

Comments

@multiplehats
Copy link

multiplehats commented Dec 16, 2020

First off, thanks for building this! It really saved me a lot of time.

Quick question, I'm releasing a plugin to wp.org and one of the requirements (in the plugin guidelines handbook) is that you provide unminified assets: see here

I searched but couldn't immediately find my question in any (past) issues.

How does one build for production with both .js and .min.js?

You can see Elementor is doing something similar. This is what their production build looks like.
Screenshot 2020-12-16 at 17 10 19

@swashata
Copy link
Owner

Hi,

Thank you for your good words :)

I have never faced any such issue. The guideline says, you can link to the original repository. Maybe you can just include the source files if that is not an option.

In any case, if you can figure out and send a PR to generate .min.js and unminified files and enqueue only .min by default, we can surely merge it.

@swashata swashata added help wanted Extra attention is needed Status: PR Welcome Type: Feature New feature or request labels Dec 20, 2020
@multiplehats
Copy link
Author

Thanks @swashata , I'm not an expert ono this, but I'll see what I can do. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Status: PR Welcome Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants