Using dynamic Imports with a CDN

[derweili]

I created the followin issue swashata/wp-webpack-script#1230 on the wp-webpack-script repo but I think it's better located here

Problem Description

For using CDNs, this variable needs to be set to the CDNs URL instead of the WordPress URL.
The docs already mention this case:

For example, we could very much put all the files inside dist to a CDN, and change publicPath to https://cdn.example.com/path/to/asset/dir.

Possible Solution

I checked the source code and I think this could easily be solved by adding a filter to the Enqueue::getUrl() method before returning the value.

wpackio-enqueue/inc/Enqueue.php

Lines 398 to 400 in 8a5604f

	public function getUrl( $asset ) {
	return $this->rootUrl . $asset;
	}

Any thoughts about that?

[swashata]

Yes you are correct. Also along with filtering the output of getUrl, I think we can also filter the output of printPublicPath for more extensibility.

wpackio-enqueue/inc/Enqueue.php

Lines 145 to 149 in 8a5604f

	public function printPublicPath() {
	$publicPath = $this->getUrl( '' );
	$jsCode = 'window.__wpackIo' . $this->sanitize_path( $this->appName . $this->outputPath ) . '=\'' . esc_js( $publicPath ) . '\';';
	echo '<script type="text/javascript">/* wpack.io publicPath */' . $jsCode . '</script>';
	}