Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated solution to hide web components #4542

Open
alizedebray opened this issue Jan 29, 2025 · 1 comment · May be fixed by #4680
Open

Automated solution to hide web components #4542

alizedebray opened this issue Jan 29, 2025 · 1 comment · May be fixed by #4680
Assignees
@myrta2302
Labels
📦 components Related to the @swisspost/design-system-components package 📦 styles Related to the @swisspost/design-system-styles package ⏲ timeboxed: 4 hours Spend 4 hours on this task. If you're not able to complete it, it's not worth pursuing further.
Milestone
Maintenance III

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Jan 29, 2025 •
edited
Loading

We should find a long term solution for that.

Originally posted by @alizedebray in #4533

To have all undefined web components hidden by default we can:

  • add tests
  • generate the file
@alizedebray alizedebray added needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers 📦 components Related to the @swisspost/design-system-components package 📦 styles Related to the @swisspost/design-system-styles package labels Jan 29, 2025
@alizedebray alizedebray added this to the Maintenance III milestone Jan 29, 2025
@gfellerph gfellerph added the ⏲ timeboxed: 4 hours Spend 4 hours on this task. If you're not able to complete it, it's not worth pursuing further. label Jan 30, 2025
@gfellerph
Copy link
Member

Proposed resolution: Add a gulp task that grabs all component names before a build from the components package and then generates the file responsible for setting visibility hidden for all unregistered design system components.

@gfellerph gfellerph removed the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Jan 30, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Jan 30, 2025
@myrta2302 myrta2302 self-assigned this Feb 14, 2025
@myrta2302 myrta2302 linked a pull request Feb 14, 2025 that will close this issue
feat(styles): add gulp task to update _not-defined.scss with built components #4680
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myrta2302 myrta2302

Labels
📦 components Related to the @swisspost/design-system-components package 📦 styles Related to the @swisspost/design-system-styles package ⏲ timeboxed: 4 hours Spend 4 hours on this task. If you're not able to complete it, it's not worth pursuing further.
Projects
Design System Production Board
Status: 💻 Ready for development
Milestone
Maintenance III
3 participants
@gfellerph @alizedebray @myrta2302