Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align components prop validation #4507

Open
alizedebray opened this issue Jan 23, 2025 · 0 comments · May be fixed by #4638
Open

Align components prop validation #4507

alizedebray opened this issue Jan 23, 2025 · 0 comments · May be fixed by #4638
Assignees
@myrta2302
Labels
📦 components Related to the @swisspost/design-system-components package
Milestone
Maintenance III

Comments

@alizedebray
Copy link
Contributor

To validate the component properties we currently use the check functions to which we have to pass an error message.
It would be nice if these messages can be aligned throughout the whole component library.
The message could be generate in the check function from the this of the component.
@alizedebray alizedebray added the 📦 components Related to the @swisspost/design-system-components package label Jan 23, 2025
@alizedebray alizedebray added this to the Maintenance III milestone Jan 23, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Jan 29, 2025
@myrta2302 myrta2302 self-assigned this Feb 5, 2025
@myrta2302 myrta2302 moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Feb 7, 2025
@myrta2302 myrta2302 linked a pull request Feb 10, 2025 that will close this issue
chore(components): align prop validation messages #4638
Open
@myrta2302 myrta2302 moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myrta2302 myrta2302

Labels
📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Status: 🤬 Dev in Code Review
Milestone
Maintenance III
Development

Successfully merging a pull request may close this issue.

chore(components): align prop validation messages swisspost/design-system
2 participants
@alizedebray @myrta2302