Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

six dependency removal #101

Open
pgajdos opened this issue Jun 7, 2023 · 1 comment
Open

six dependency removal #101

pgajdos opened this issue Jun 7, 2023 · 1 comment

Comments

@pgajdos
Copy link

pgajdos commented Jun 7, 2023

As soon as python 2 support is not necessary anymore, please remove dependency on six.

Index: promise-2.3.0/promise/promise.py
===================================================================
--- promise-2.3.0.orig/promise/promise.py
+++ promise-2.3.0/promise/promise.py
@@ -5,7 +5,6 @@ from threading import RLock
 from types import TracebackType
 from weakref import WeakKeyDictionary

-from six import reraise  # type: ignore
 from .async_ import Async
 from .compat import (
     Future,
@@ -223,7 +222,7 @@ class Promise(Generic[T]):
         elif self._state == STATE_REJECTED:
             if _raise:
                 raise_val = self._fulfillment_handler0
-                reraise(type(raise_val), raise_val, self._traceback)
+                raise raise_val.with_traceback(self._traceback)
             return self._fulfillment_handler0

     def _fulfill(self, value):
@a-detiste
Copy link

Hi, tracking this issue too.

https://wiki.debian.org/Python3-six-removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants