Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator-based coroutines aren't recognized in 2.2.1 #69

Open
insolite opened this issue Jan 20, 2019 · 0 comments
Open

Generator-based coroutines aren't recognized in 2.2.1 #69

insolite opened this issue Jan 20, 2019 · 0 comments

Comments

@insolite
Copy link

Since 90093a1 the iscoroutine from inspect is used which is quite different to asyncio's. According to docs it recognizes async def. But it doesn't return true for @asyncio.coroutine functions. For them there's an isawaitable. Shouldn't it be used instead of inspect.iscoroutine? Also the inspect.iscoroutine is new in 3.5 so shouldn't we keep the asyncio.iscoroutine as a fallback option instead of removing it at all (seems like it breaks 3.4 compatibility).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant