You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since 90093a1 the iscoroutine from inspect is used which is quite different to asyncio's. According to docs it recognizes async def. But it doesn't return true for @asyncio.coroutine functions. For them there's an isawaitable. Shouldn't it be used instead of inspect.iscoroutine? Also the inspect.iscoroutine is new in 3.5 so shouldn't we keep the asyncio.iscoroutine as a fallback option instead of removing it at all (seems like it breaks 3.4 compatibility).
The text was updated successfully, but these errors were encountered:
Since 90093a1 the
iscoroutine
frominspect
is used which is quite different toasyncio
's. According to docs it recognizesasync def
. But it doesn't return true for@asyncio.coroutine
functions. For them there's an isawaitable. Shouldn't it be used instead ofinspect.iscoroutine
? Also theinspect.iscoroutine
is new in 3.5 so shouldn't we keep theasyncio.iscoroutine
as a fallback option instead of removing it at all (seems like it breaks 3.4 compatibility).The text was updated successfully, but these errors were encountered: