Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't match in checkSimilarity on template name value, just template column key #227

Open
johnwards opened this issue May 17, 2024 · 0 comments

Comments

@johnwards
Copy link

We've been scratching our heads why a template value that looks like this:

 {
  name: "Extra Info",
   key: "extraInfo",
 }

Doesn't match when we upload a file with the column header Extra Info

Turns out there are 2 issues.

  1. the stringsSimilarity code doesn't like camelCase strings, only snake_case
  2. checkSimilarity only takes the templateColumKey, not the templateColumnName value.

Have I misunderstood how this should work? I'm happy to submit a patch if you want the 2 issues fixed.

To get around this we've had to add suggested_mappings: ["Extra Info"] to our template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant