Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - Reorder - items moves incorrectly when continuously dragging or when the container is overflowed #6576

Open
4 of 9 tasks
baltzarmattsson opened this issue Jan 26, 2024 · 6 comments · May be fixed by #10360
Open
4 of 9 tasks
Assignees
Labels
contributions welcome Architecture is clear and community can help P3 This issue has low priority S3 This issue has low severity

Comments

@baltzarmattsson
Copy link

Playground Link

https://stackblitz.com/edit/angular-tiprds?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.component.html

Description

Hi, thanks for a great library. The items moves weirdly when either moving the item continuously or when the container overflows.

Moving continously:

movecont.mp4

Overflow (I mousewheel down when reaching item 14)

overflow.mp4

Angular version

16.0.0

Taiga UI version

3.40.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@waterplea
Copy link
Collaborator

It is working as expected in terms of it switches two items positions, not moves your current item in the new place while shifting all items in between. It does look a bit weird when dragging fast like that, I wonder what can we do about it that does not require rewriting the overall principle of tiles, a component which is underneath 🤔

@40oleg
Copy link
Collaborator

40oleg commented Feb 5, 2024

May I take this problem?

@waterplea
Copy link
Collaborator

May I take this problem?

What's your plan for it?

@waterplea waterplea added P3 This issue has low priority S3 This issue has low severity and removed state: need triage labels Feb 26, 2024
@waterplea
Copy link
Collaborator

We can probably add some sort of different mode behavior — switching places, as it does now, or shifting it in an array from one place to the other. First mode makes more sense for 2d plane while that new one would work better for a single column view

@waterplea waterplea added the contributions welcome Architecture is clear and community can help label Nov 6, 2024
@splincode splincode removed the bug label Nov 11, 2024
@kulagind
Copy link

Hi there! I'll take it. I suppose it consists of 2 parts - add possibility of shifting behaviour (leaving current "swap" behaviour by default) and fixing scroll while drag element in long list

@waterplea
Copy link
Collaborator

@kulagind let's only fix the first part for now, I'm not sure we should add scroll into the drag. The scrolling containers can be very diverse, it would be easier to externally add some invisible DIV when an item is dragged and do some action like scrolling when you hover over it than try and guess what to do inside the dragging directives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Architecture is clear and community can help P3 This issue has low priority S3 This issue has low severity
Development

Successfully merging a pull request may close this issue.

5 participants