Add continuous scrolling speed adjustment #1649

FireChickenProductivity · 2024-12-21T23:08:40Z

Add the ability to adjust continuous scrolling speed while scrolling by dictating a number_small. The speed becomes the speed setting multiplied by the dictated number divided by ten. The acceleration gets reset every time the speed gets changed. The scrolling speed reverts to the default after the current scroll is finished.
closes #1648

for more information, see https://pre-commit.ci

FireChickenProductivity · 2024-12-21T23:28:20Z

I added the ability to set the scrolling speed when starting continuous scrolling.

plugin/mouse/mouse_scroll.py

plugin/mouse/mouse.talon

for more information, see https://pre-commit.ci

FireChickenProductivity · 2024-12-31T17:30:22Z

I found a bug that should be resolved before merge.

FireChickenProductivity · 2024-12-31T17:36:15Z

Actually, the "issue" seems to happen without my pull request. Is it intended for some reason for using the continuous scrolling action twice in the same direction to stop the scrolling completely?

AndreasArvidsson · 2024-12-31T19:35:08Z

Yes that is on purpose. For people using a foot switch, noise or other to toggle the scrolling on and off.

AndreasArvidsson · 2025-01-11T17:23:35Z

@knausj85 Will test this. If someone else has time before that please go ahead.

knausj85 · 2025-01-12T19:36:39Z

plugin/mouse/mouse_scroll.py

@@ -181,13 +206,17 @@ def mouse_scroll_continuous(new_scroll_dir: Literal[-1, 1]):
        continuous_scroll_mode = "scroll down continuous"


As written, I believe this will always display "scroll down continuous"

I tested that and can confirm, but I am not sure if I should change that here if the preference is for atomic pull requests.

I fixed that.

knausj85 · 2025-01-12T19:43:02Z

plugin/mouse/continuous_scrolling.talon

@@ -0,0 +1,3 @@
+tag: user.continuous_scrolling


I think we need to ensure this coexists well with the tag user.numbers_unprefixed. Since the talon files have the same specificity, it's ambiguous which one talon will choose. Probably just add not tag: user.continuous_scrolling to that file

specificity doesn't work on commands right now besides exact matches. it's pretty complicated to factor in .talon specificity in the command parser. action-level overrides are much easier to reason about

In this case, the commands are not an exact match. unprefixed numbers use a different capture, so I don't think an action really nets us anything in this context either.

knausj85 · 2025-01-12T20:07:34Z

plugin/mouse/mouse_scroll.py


 from talon import Context, Module, actions, app, cron, ctrl, imgui, settings, ui

+DEFAULT_CONTINUOUS_SCROLLING_SPEED_FACTOR: int = 10


I'm inclined to make this a setting. Any reason not to do so?

I can make that change.

I made it a setting.

knausj85 · 2025-01-12T20:24:14Z

Actually, the "issue" seems to happen without my pull request. Is it intended for some reason for using the continuous scrolling action twice in the same direction to stop the scrolling completely?

I initially thought this was a bug too; these commands used to be compatible with repeaters and such. I guess I missed that memo!

If needed, we can explore how to make these more friendly for hotkeys / pedals in a separate issue

I tested this a bit and it's a great improvement. I've a few minor suggestions before we merge.

for more information, see https://pre-commit.ci

This reverts commit 3ed0a38.

…hickenProductivity/knausj_talon into pr/1649

for more information, see https://pre-commit.ci

- the

…hickenProductivity/knausj_talon into pr/1649

for more information, see https://pre-commit.ci

knausj85 · 2025-01-12T22:22:14Z

Actually, the "issue" seems to happen without my pull request. Is it intended for some reason for using the continuous scrolling action twice in the same direction to stop the scrolling completely?

There is a separate few bugs with this logic though that we might as well fix while we're here:

the imgui should probably close & tag be cleared when this happens.

I took a quick swing at fixing that.

FireChickenProductivity · 2025-01-16T01:58:34Z

I identified an issue where if the scrolling speed becomes less than one but non-zero the result is no scrolling. Should I address that by rounding up? (This can happen when trying to set the scrolling speed to a small number)

FireChickenProductivity · 2025-01-16T02:15:35Z

It looks like float values for the scrolling speed get truncated, so changing the scrolling speed from some values to certain other values through voice commands has no effect. I am not sure if we should try to address that to make increasing speed value always increase the actual scrolling speed, but the issue is worth noting.

for more information, see https://pre-commit.ci

nriley · 2025-01-18T17:44:46Z

plugin/mouse/continuous_scrolling.talon

@@ -0,0 +1,3 @@
+tag: user.continuous_scrolling
+-
+<number_small>: user.mouse_scroll_set_speed(number_small)


On the community backlog session we recommended that you add a graphical display of the presence of this feature.

nriley · 2025-01-18T17:45:43Z

plugin/mouse/mouse_scroll.py

@@ -115,10 +127,12 @@ def mouse_gaze_scroll_toggle():

    def mouse_scroll_stop() -> bool:
        """Stops scrolling"""
-        global scroll_job, gaze_job, continuous_scroll_mode, control_mouse_forced
+        global scroll_job, gaze_job, continuous_scroll_mode, control_mouse_forced, continuous_scrolling_speed_factor, ctx


You don't need ctx here unless you're writing directly to it.

nriley · 2025-01-18T17:47:38Z

plugin/mouse/mouse_scroll.py

+
+    def mouse_is_continuous_scrolling():
+        """Returns whether continuous scroll is in progress"""
+        if continuous_scroll_mode:


Consider return continuous_scroll_mode != ""

nriley · 2025-01-18T17:48:33Z

plugin/mouse/mouse_scroll.py

+    new_scroll_dir: Literal[-1, 1],
+    speed_factor: Optional[int] = None,
+):
+    global scroll_job, scroll_dir, scroll_start_ts, ctx


Please remove ctx as above

FireChickenProductivity and others added 4 commits December 21, 2024 16:05

Add continuous scrolling speed adjustment

cbabb6f

[pre-commit.ci] auto fixes from pre-commit.com hooks

8a50d43

for more information, see https://pre-commit.ci

Add ability to set speed with scrolling commands

128a4f5

[pre-commit.ci] auto fixes from pre-commit.com hooks

1f3c8fb

for more information, see https://pre-commit.ci

AndreasArvidsson requested changes Dec 28, 2024

View reviewed changes

plugin/mouse/mouse_scroll.py Outdated Show resolved Hide resolved

plugin/mouse/mouse_scroll.py Outdated Show resolved Hide resolved

plugin/mouse/mouse.talon Outdated Show resolved Hide resolved

FireChickenProductivity and others added 6 commits December 29, 2024 15:28

Remove unneeded context

eaf2df4

Create default factor constant

f27b7ad

Use optional integers

fd66564

[pre-commit.ci] auto fixes from pre-commit.com hooks

9f451a7

for more information, see https://pre-commit.ci

Make alternate version of commands without argument

e10b3a6

[pre-commit.ci] auto fixes from pre-commit.com hooks

a008edd

for more information, see https://pre-commit.ci

FireChickenProductivity closed this Jan 2, 2025

FireChickenProductivity deleted the adjustable-scrolling-speed branch January 2, 2025 22:08

FireChickenProductivity restored the adjustable-scrolling-speed branch January 2, 2025 22:08

FireChickenProductivity reopened this Jan 2, 2025

Merge branch 'main' into adjustable-scrolling-speed

9b5d0da

knausj85 reviewed Jan 12, 2025

View reviewed changes

knausj85 and others added 5 commits January 12, 2025 13:50

Update mouse.py

3ed0a38

[pre-commit.ci] auto fixes from pre-commit.com hooks

7ac5ecd

for more information, see https://pre-commit.ci

Revert "Update mouse.py"

a413cff

This reverts commit 3ed0a38.

Merge branch 'adjustable-scrolling-speed' of https://github.com/FireC…

957d200

…hickenProductivity/knausj_talon into pr/1649

[pre-commit.ci] auto fixes from pre-commit.com hooks

fb3d71a

for more information, see https://pre-commit.ci

knausj85 and others added 3 commits January 12, 2025 15:17

Update mouse_scroll.py

25d164f

- the

Merge branch 'adjustable-scrolling-speed' of https://github.com/FireC…

0151e70

…hickenProductivity/knausj_talon into pr/1649

[pre-commit.ci] auto fixes from pre-commit.com hooks

c2ba66e

for more information, see https://pre-commit.ci

FireChickenProductivity and others added 3 commits January 15, 2025 19:18

Make speed quotient a setting

078e207

Address scrolling mode inconsistency

ce2a48d

[pre-commit.ci] auto fixes from pre-commit.com hooks

5747535

for more information, see https://pre-commit.ci

nriley requested changes Jan 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add continuous scrolling speed adjustment #1649

Add continuous scrolling speed adjustment #1649

FireChickenProductivity commented Dec 21, 2024

FireChickenProductivity commented Dec 21, 2024

FireChickenProductivity commented Dec 31, 2024

FireChickenProductivity commented Dec 31, 2024

AndreasArvidsson commented Dec 31, 2024

AndreasArvidsson commented Jan 11, 2025

knausj85 Jan 12, 2025

FireChickenProductivity Jan 16, 2025

FireChickenProductivity Jan 16, 2025

knausj85 Jan 12, 2025

lunixbochs Jan 12, 2025 •

edited

Loading

knausj85 Jan 12, 2025

knausj85 Jan 12, 2025

FireChickenProductivity Jan 16, 2025

FireChickenProductivity Jan 16, 2025

knausj85 commented Jan 12, 2025

knausj85 commented Jan 12, 2025

FireChickenProductivity commented Jan 16, 2025

FireChickenProductivity commented Jan 16, 2025

nriley Jan 18, 2025

nriley Jan 18, 2025

nriley Jan 18, 2025

nriley Jan 18, 2025

		@@ -181,13 +206,17 @@ def mouse_scroll_continuous(new_scroll_dir: Literal[-1, 1]):
		continuous_scroll_mode = "scroll down continuous"


		from talon import Context, Module, actions, app, cron, ctrl, imgui, settings, ui

		DEFAULT_CONTINUOUS_SCROLLING_SPEED_FACTOR: int = 10

Add continuous scrolling speed adjustment #1649

Are you sure you want to change the base?

Add continuous scrolling speed adjustment #1649

Conversation

FireChickenProductivity commented Dec 21, 2024

FireChickenProductivity commented Dec 21, 2024

FireChickenProductivity commented Dec 31, 2024

FireChickenProductivity commented Dec 31, 2024

AndreasArvidsson commented Dec 31, 2024

AndreasArvidsson commented Jan 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunixbochs Jan 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

knausj85 commented Jan 12, 2025

knausj85 commented Jan 12, 2025

FireChickenProductivity commented Jan 16, 2025

FireChickenProductivity commented Jan 16, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunixbochs Jan 12, 2025 •

edited

Loading