Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: also checks fmt #27

Open
panglesd opened this issue May 11, 2022 · 3 comments
Open

CI: also checks fmt #27

panglesd opened this issue May 11, 2022 · 3 comments
Labels
CI

Comments

@panglesd
Copy link
Contributor

Currently the (unmerged) CI does not check if the code is ocamlformat-idempotent.
@panglesd panglesd added the CI label May 12, 2022
@pitag-ha
Copy link
Member

What are you referring to? Are you referring to checking if our code itself is formatted? Or are you referring to some check about the installation of ocamlformat by the ocaml-platform installer?

@panglesd
Copy link
Contributor Author

Are you referring to checking if our code itself is formatted?

yes

@Julow
Copy link
Member

Julow commented Jun 1, 2022

ocaml-ci does that and we should use it. We don't build a CI for everything, we build a CI for releasing and for the resources-heavy tests we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Julow @panglesd @pitag-ha