-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impossible to create multi-values search for issues with multiple filters #360
Comments
you are welcome to submit a PR with a fix. |
This issue is a showstopper for us, as we need multiple free-form filters. I see that PR #340 was closed — and for good reason, because the second fix clearly introduced another bug. But why was its original fix (Remove distinct) replaced? I.e. why do duplicate param names need to be removed at all? (Looks like that was added in PR #335, but I can't see why.) As I understand it, a trailing Also, all the unit tests are failing because dev.taskadapter.com isn't reachable. Is there an alternative site, or another way to run them? |
Suggested fix for issues taskadapter#360 and taskadapter#339. Preserves duplicate params with names ending in `[]` (needed for free-form Redmine queries), while still removing others.
the dev server is turned off indeed. I would recommend downloading a Redmine docker image and running the tests against your local Redmine copy (after updating the test configs - urls, passwords,..) |
code sample:
using:
actual query:
/issues.json?set_filter=1&v%5Btracker_id%5D%5B%5D=2&v%5Bsubject%5D%5B%5D=sample+subject&op%5Bsubject%5D=%7E&op%5Btracker_id%5D=%3D&f%5B%5D=subject
expected query:
/issues.json?set_filter=1&v%5Btracker_id%5D%5B%5D=2&v%5Bsubject%5D%5B%5D=sample+subject&op%5Bsubject%5D=%7E&op%5Btracker_id%5D=%3D&f%5B%5D=tracker_id&f%5B%5D=subject
The text was updated successfully, but these errors were encountered: