Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] tauri migrate shoud migrate main bin name to product name #10548

Closed
anatawa12 opened this issue Aug 9, 2024 · 4 comments
Closed

[feat] tauri migrate shoud migrate main bin name to product name #10548

anatawa12 opened this issue Aug 9, 2024 · 4 comments

Comments

@anatawa12
Copy link
Contributor

Describe the problem

#9375 removed renaming binary to product name specified in Tauri.toml.

However, this is not migrated with tauri migrate and unexpectedly broke user installed shortcuts

Describe the solution you'd like

I think it's much better to migrate main bin name to product name in tauri migrate command.

I'm going to create issue for documentation.

Alternatives considered

No response

Additional context

No response

@amrbashir
Copy link
Member

amrbashir commented Aug 13, 2024

Can you explain how #9375 broke your user shortcut? did you update from a version that was using tauri@beta?

We have code specifically for updating the shortcut upon updates to use the new bin name.

@anatawa12
Copy link
Contributor Author

did you update from a version that was using tauri@beta?

No, I'm migrating from tauri v1 to v2 rc.

We have code specifically for updating the shortcut upon updates to use the new bin name.

At least for my case, app pinned onto task bar is still refering old (ProductName-based) exe name after installing with nsis installer.

@krlvi
Copy link

krlvi commented Sep 7, 2024

Hey @anatawa12, we are running into the same issue, I'm gonna try adding an option to get the compatible v1 behavior here gitbutlerapp#1

@amrbashir
Copy link
Member

fixed in #10977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants