Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl object model test coverage #1353

Open
littledan opened this issue Nov 21, 2017 · 0 comments
Open

Intl object model test coverage #1353

littledan opened this issue Nov 21, 2017 · 0 comments

Comments

@littledan
Copy link
Member

littledan commented Nov 21, 2017

From #1350, @leobalter wrote,

The resolveOptions still return an object which prototype is %ObjectPrototype%.

I think it's valuable to check this is still effective, so one can benefit of this inheritance for the returned value (using toString, etc).

One other good thing for this test is: GetOption should not trigger any observable behaving on the Object.prototype for this new created options. You can verify it this using a Object.defineProperty(Object.prototype, "type", { get() { throw new Test262Error() } } );. This way you also assert the proper GetOption(options, type, ... operation.

We should test this on all Intl resolvedOptions return values.

I bet there are lots of object model sort of interactions that lack detailed test coverage. Until recently, there wasn't even a test of whether the prototypes of Intl objects were instances of their class, for example. This is worthy of a thorough look through the spec and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants