-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML formatting restrictions #1997
Comments
Looks like JSC's parser is having trouble with the YAML as well: https://bugs.webkit.org/show_bug.cgi?id=193053 |
@gsathya yes, the issues we can list here might affect at least V8, JSC and SpiderMonkey. Turns out it Yaml parsers are more challenging than one can expect. Edit: For clarification, my goal is to tackle these issues and provide a consistent format to avoid any problem when consuming test262 in other projects. |
Another one: #2034 |
Thanks for working on this important issue, @leobalter. |
Would it also be possible to prohibit inline value strings that span multiple lines? That seems to cause issues for JSC's YAML parser... For example:
Ideally, this would be formatted as one line or with "|"/">" |
Opened #2505 to address the specific issue @kmiller68 identified. |
Includes key should use flow notation to be able parsed easier as suggested in tc39#1997 Added this check to the linting script and updated tests accordingly.
Includes key should use flow notation to be able parsed easier as suggested in #1997 Added this check to the linting script and updated tests accordingly.
The phase field must precede the type field for negative tests to have a consistent style and be able to parse easier. Related to the goal of tc39#1997 Added this check to the linting script and updated tests accordingly.
The phase field must precede the type field for negative tests to have a consistent style and be able to parse easier. Related to the goal of #1997 Added this check to the linting script and updated tests accordingly.
We should restrict the YAML format for the test files frontmatter to improve interoperability.
Many test runners depend on quick but limited yaml parsers and it's ok to have style restrictions identified in the importing processes for Test262.
Some of them I can already tell from scratch:
[ leading-space, foo, trailing-space ]
There are might be more items we want to identify here. We should increase the list as necessary.
cc @caitp @gsathya @psmarshall
The text was updated successfully, but these errors were encountered: