Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in additional coverage for String.localeCompare #3244

Open
schuay opened this issue Oct 6, 2021 · 2 comments
Open

Pull in additional coverage for String.localeCompare #3244

schuay opened this issue Oct 6, 2021 · 2 comments

Comments

@schuay
Copy link
Contributor

schuay commented Oct 6, 2021

The current coverage seems fairly basic and is missing many relevant special cases. I'd suggest to pull in at JSC's https://github.com/WebKit/WebKit/blob/main/JSTests/stress/string-localeCompare.js.

Besides that, it may make sense to add further coverage.

cc @mathiasbynens @FrankYFTang

@mathiasbynens
Copy link
Member

cc @jugglinmike @anba

@jugglinmike
Copy link
Contributor

Improving coverage always sounds good to me!

Here's a few tips for anyone who wants to take up the cause:

  • in recognition of the optional nature of ECMA402, Test262 maintains tests for the String.prototype.localeCompare method in two different places: test/intl402/String/prototype/localeCompare/ and test/built-ins/String/prototype/localeCompare/. New tests should go in the former directory if they concern normative text in ECMA402, and they should go in the latter if they concern normative text in ECMA262.
  • the referenced JSC stress test seems like a great source of inspiration. To make its assertions useful for conformance testing, please separate them into distinct files whose description metadata explains their intent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants