-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing tests forbidding Date.parse output with fractional part #3437
Comments
I think
|
To copy from https://bugs.webkit.org/show_bug.cgi?id=238050#c5 , But regardless, https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date.parse is underspecified and it is not the proper place of test262 to correct that. Enforcement here should be limited to verifying the absence of fractional data. |
It looks inconsistent to me. |
I responded at https://bugs.webkit.org/show_bug.cgi?id=238050#c7 , but the summary is that the only cases where input to TimeClip can have a nonempty fractional component correspond with source text providing a single number to a date function ( But with that, I am done with this thread. As I said above, enforcement within test262 should be limited to verifying the absence of fractional data output from |
The algorithm at https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date.parse requires returning a time value—"either a finite integral Number representing an instant in time to millisecond precision or NaN representing no specific instant". This should be covered by tests, to avoid violations as seen in JavaScriptCore:
Every engine except JavaScriptCore seems to get this right, and a bug has now been reported there: https://bugs.webkit.org/show_bug.cgi?id=238050
The text was updated successfully, but these errors were encountered: