Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect features tag in test #3461

Open
FrankYFTang opened this issue Apr 1, 2022 · 1 comment
Open

Incorrect features tag in test #3461

FrankYFTang opened this issue Apr 1, 2022 · 1 comment

Comments

@FrankYFTang
Copy link
Contributor

FrankYFTang commented Apr 1, 2022

There should have no spaces before that in the line.

~/tc39/test262$ find |egrep [\.]js| xargs egrep  " features:"
./test/built-ins/Promise/prototype/then/ctor-throws.js:    features: [Symbol.species]
./test/language/expressions/object/method-definition/yield-as-parameter.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-logical-or-expression.js:  features: [generators]
./test/language/expressions/object/method-definition/generator-no-yield.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-literal-property-name.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-weak-binding.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-generator-method-binding-identifier.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-star-after-newline.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-property-name.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-function-expression-binding-identifier.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-expression-with-rhs.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-yield-operand.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-expression-without-rhs.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-newline.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-star-before-newline.js:  features: [generators]
./test/language/expressions/object/method-definition/generator-return.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-identifier-in-nested-function.js:  features: [generators]
./test/language/expressions/object/method-definition/yield-as-statement.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-expression-without-rhs.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-no-yield.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-star-before-newline.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-property-name.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-yield-operand.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-star-after-newline.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-newline.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-generator-method-binding-identifier.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-return.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-statement.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-weak-binding.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-expression-with-rhs.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-identifier-in-nested-function.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-parameter.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-logical-or-expression.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-function-expression-binding-identifier.js:  features: [generators]
./test/language/statements/class/definition/methods-gen-yield-as-literal-property-name.js:  features: [generators]

I think most of them are landed by @rkirsling

@ptomato
Copy link
Contributor

ptomato commented Apr 11, 2022

What you say seems correct. Would you like to make a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants