-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing ROOT_URL in the '.env' file does not have the desired effect #57
Comments
When another hackathon ran into this issue a little while ago, there were a few additional things that needed to be done:
Let me know if this fixes the problem! If you have an idea of how to pull this out into nice config settings so this is clearer / easier for other people in the future, feel free to put in a PR :) |
Hi Jessy, Thank you for taking the time to respond. Surprisingly I managed to figure most of it out on my own but it required a fair amount more than those two steps. Although I had prior experience with Linux and Nginx, I am still very much a beginner to Node.js. However, Google came to the rescue. When I meet with my peers, we will try to improve upon the work I've done to make a pull request related to this issue, so others can replicate what we did without the same struggle I had. :P Our fork of the repo can be found here: https://github.com/ElectronicsOSU/quill-MakeOHIO-2018 Thanks, |
That would be awesome, @DaleMitchell, I think this would be in high demand since we've seen many other hackathons trying the same thing. Keep us updated on whether you're planning to work on this! |
Buckeye Hackers will host "Hack the Hack" on February 3 on Ohio State's campus at the 18th Ave Library (Room 070) from about 10 AM to 4 PM. The goal of the event is to improve anything related to our hackathon program. I'll be there to push this as a priority at the event, so we should be able to get most of it done. |
We made a lot of progress but there are some finishing touches that still need to be completed. I'll revisit this issue next weekend. |
Made a commit related to this issue to our fork for MakeOHI/O. See ElectronicsOSU@0dd81bf Also need to add documentation for using Nginx as a proxy (so Quill can be accessed from the same webserver as the event website, which was the intent of bringing this issue forward). Perhaps this addition to the readme:
I'd like to make a pull request with these changes but since we just used the whole fork we made for our event there will be conflicts due to our branding and other features we have implemented. After acknowledging this, I think that it would be best for me to make a new branch just to make improvements/add features in order to keep them separate from customizations like branding (maybe I'll call the branch that I'm describing 'vanilla', seems like a good choice, also makes me hungry for some vanilla ice cream lol). |
With that said, I'm pretty busy and need to prioritize schoolwork, but if someone wants to beat me to a pull request for this issue, feel free! |
Also interesting how a different Node.js project accomplished the feature related to this issue:
|
I want to host Quill on the same domain as our event website, ie.
event website: make.osu.edu
event registration: make.osu.edu/register/
So I changed ROOT_URL in the '.env' file but, as my title of this issue reflects, it no workie workie.
Any ideas?
The text was updated successfully, but these errors were encountered: