You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As you can see from the docker images, redis uses CMD [redis-server] but redis-stack-server uses a custom entrypoint script. So I'm happy to open a PR, basically based on image string passed, we'll need to change how container.start() is handled (It's messy but not sure how else to solve it when you have 2 Redis images now!)
/* Make sure the redis image is a not a `redis-stack` image as `redis-stack` images have a custom entrypoint, see https://hub.docker.com/r/redis/redis-stack-server */if(!this.imageName.image.includes("redis-stack")){this.withCommand(["redis-server",
...(this.password ? [`--requirepass "${this.password}"`] : []),
...(this.persistenceVolume ? ["--save 1 1 ","--appendonly yes"] : []),]);}
With redis-stack this.withCommand will not be applicable as all custom args are passed via env vars.
Expected Behaviour
This will fail because of the
redis-server
command.testcontainers-node/packages/modules/redis/src/redis-container.ts
Lines 36 to 39 in 9f7fd4e
As you can see from the docker images,
redis
usesCMD [redis-server]
butredis-stack-server
uses a custom entrypoint script. So I'm happy to open a PR, basically based on image string passed, we'll need to change howcontainer.start()
is handled (It's messy but not sure how else to solve it when you have 2 Redis images now!)The text was updated successfully, but these errors were encountered: