Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Checkbox should extend built-in props #243

Open
thien-do opened this issue Jun 30, 2021 · 1 comment
Open

Feat: Checkbox should extend built-in props #243

thien-do opened this issue Jun 30, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@thien-do
Copy link
Owner

Continue of #160

Should be like #239 but for Checkbox
@lqt93 lqt93 added enhancement New feature or request good first issue Good for newcomers labels Jun 30, 2021
@thien-do thien-do removed the good first issue Good for newcomers label Jul 3, 2021
@thien-do
Copy link
Owner Author

thien-do commented Jul 3, 2021

Well this turns out to be harder than I think. The problem is we are heavily using an internal ref at Checkbox to support the "indeterminate" prop, which is quite wrong IMO. However, removing support for this would be a breaking change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thien-do @lqt93