Add support for Buffer values #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to avoid @types/node if possible, as the sqlite package targets browsers. Will take a look at this in a couple hours :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
The solution is a bit more complex because I don't have access to the
Buffertype. If I try to access the type, I get the following error:This PR implements a Buffer check that does not rely on
@types/nodeto be installed, even though, I would much prefer that solution. The mysql package is built on top of mariadb which is a nodejs-specific implementation. However, I wasn't sure about the platform-specificity of this repo.@tim-smart any objections against pulling in
@types/node? If the packages should be platform-agnostic, I think there's some extra work to do to achieve that for the mysql package, at least.