Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to a newer version of YamlDotNet #144

Open
tomsseisums opened this issue Oct 20, 2021 · 1 comment
Open

Upgrade to a newer version of YamlDotNet #144

tomsseisums opened this issue Oct 20, 2021 · 1 comment

Comments

@tomsseisums
Copy link
Contributor

The project depends on YamlDotNet 6.1.2, where the latest is 11.2.1.

<PackageReference Include="YamlDotNet" Version="6.1.2" />

We hadn't explicitly added YamlDotNet to our project and relied on the internal dependency provided by KubeClient, we ended up having a threading problem related to deserialization which got resolved by explicitly upgrading to a later version.

I came to realization to upgrade by checking YamlDotNet's code and I found out that the v6 implementation in some places are not async/threading friendly, our case was one of them.

The project works otherwise, so I'd imagine it's a safe upgrade.

@tintoy
Copy link
Owner

tintoy commented Oct 20, 2021

Thanks! I’ll give this a try and if the tests still pass I’ll put out a new release sometime today 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants