-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to add more than one config map #96
Comments
Yeah - I can see why that doesn’t work (to be honest I’ve never tried using more than one ConfigMap to source configuration from) but it’s a valid use case. I should be able to add support for multiple over the weekend (it’s because there’s only a single set of properties in the dictionary of provider settings and I was too lazy to create a class to model those settings - I’ll switch to storing a list of objects representing the provider settings). |
Thanks for the quick update - just wanted to let you know that it doesn't seem to fix my problem. |
This is with the code I just committed? |
(8da7227 ?) |
Sorry - I naively assumed this commit was present in 2.3.2. |
No problem - will get you a build you can try out :) |
There's a development package feed at https://www.myget.org/F/dotnet-kube-client/api/v3/index.json - are you able to try installing version |
Tested it locally now, and both configmaps are now loaded and provide configuration. Thanks! |
Thanks for testing so quickly! I'll look into #101 sometime tomorrow (it's 10pm here and I have an early start). |
builder .AddKubeConfigMap(client, "config") .AddKubeConfigMap(client, "jaeger") ;
This results in the following trace - i.e. only the last ConfigMap is read, and it is read twice.
(It doesn't exist in this test, but that's besides the point :-))
trce: KubeClient.Extensions.Configuration.ConfigMapConfigurationProvider[0] Attempting to load ConfigMap jaeger in namespace f... dbug: KubeClient.KubeApiClient.Http[100] Performing GET request to 'https://10.96.0.1/api/v1/namespaces/f/configmaps/jaeger'. dbug: KubeClient.KubeApiClient.Http[110] Completed GET request to 'https://10.96.0.1/api/v1/namespaces/f/configmaps/jaeger' (NotFound). trce: KubeClient.Extensions.Configuration.ConfigMapConfigurationProvider[0] ConfigMap jaeger was not found in namespace f (isReload: False). trce: KubeClient.Extensions.Configuration.ConfigMapConfigurationProvider[0] Attempting to load ConfigMap jaeger in namespace f... dbug: KubeClient.KubeApiClient.Http[100] Performing GET request to 'https://10.96.0.1/api/v1/namespaces/f/configmaps/jaeger'. dbug: KubeClient.KubeApiClient.Http[110] Completed GET request to 'https://10.96.0.1/api/v1/namespaces/f/configmaps/jaeger' (NotFound). trce: KubeClient.Extensions.Configuration.ConfigMapConfigurationProvider[0] ConfigMap jaeger was not found in namespace f (isReload: False).
The text was updated successfully, but these errors were encountered: