Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When importing variables, import as Theme groups #3260

Open
six7 opened this issue Feb 12, 2025 · 0 comments · May be fixed by #3270
Open

When importing variables, import as Theme groups #3260

six7 opened this issue Feb 12, 2025 · 0 comments · May be fixed by #3270
Assignees
Labels
💡request Community feedback

Comments

@six7
Copy link
Collaborator

six7 commented Feb 12, 2025

Currently when users import variables we only create or update a token set with the name of the collection.

However, we do not create theme groups for them. This leaves users with half the job done, and half still to do manually. We can optimize this.

Introducing theme group creation on import

When importing variables, we will from now on

  • look at the name of the variable collection and the modes that would be imported, for this example let's use Collection name: Theme Mode name: Light
  • inside the plugin, look at if the user is a [Pro] user. If they are NOT, do nothing
  • if they are a [Pro] user, check to see if they have any theme groups, and if so, if any theme group's name matches the collection name
  • if no theme group name that we need exists
    • create a theme group with the name of the Collection
    • inside that theme group, create theme options with the name of each Mode, with the "enabled sets" as the sets that is used for that (which we even today create or populate, so we have that logic in already, we just need to create the theme options with the right sets)
  • if a theme group exists already with that collection name
    • Look at the theme options to see if we need to create any new ones, or if we can leave it as is
@six7 six7 added the 💡request Community feedback label Feb 12, 2025
@six7 six7 moved this from 📥 Triage to 📤 Ready for dev in Tokens Studio for Figma Roadmap Feb 12, 2025
@akshay-gupta7 akshay-gupta7 self-assigned this Feb 17, 2025
@akshay-gupta7 akshay-gupta7 linked a pull request Feb 18, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡request Community feedback
Projects
Status: 📤 Ready for dev
Development

Successfully merging a pull request may close this issue.

2 participants