Draft: Google Picker #5443
Open
Draft: Google Picker #5443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected]), npm/[email protected]), npm/[email protected]) |
Diff output filesdiff --git a/packages/@uppy/provider-views/lib/index.js b/packages/@uppy/provider-views/lib/index.js
index 3e5b730..319f9c4 100644
--- a/packages/@uppy/provider-views/lib/index.js
+++ b/packages/@uppy/provider-views/lib/index.js
@@ -1,2 +1,3 @@
+export { default as GooglePickerView } from "./GooglePicker/index.js";
export { default as ProviderViews, defaultPickerIcon } from "./ProviderView/index.js";
export { default as SearchProviderViews } from "./SearchProviderView/index.js";
diff --git a/packages/@uppy/transloadit/lib/index.js b/packages/@uppy/transloadit/lib/index.js
index 5d77af0..6e48521 100644
--- a/packages/@uppy/transloadit/lib/index.js
+++ b/packages/@uppy/transloadit/lib/index.js
@@ -458,6 +458,7 @@ function _getClientVersion2() {
addPluginVersion("Facebook", "uppy-facebook");
addPluginVersion("GoogleDrive", "uppy-google-drive");
addPluginVersion("GooglePhotos", "uppy-google-photos");
+ addPluginVersion("GooglePicker", "uppy-google-picker");
addPluginVersion("Instagram", "uppy-instagram");
addPluginVersion("OneDrive", "uppy-onedrive");
addPluginVersion("Zoom", "uppy-zoom"); |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial POC of Google Picker.
closes #5382
How to test:
Google Developer console setup
Instructions for enabling the Picker API in the Google Developer console for the first time:
apiKeyclientIdappIdNow set
VITE_GOOGLE_PICKER_CLIENT_ID,VITE_GOOGLE_PICKER_API_KEY,VITE_GOOGLE_PICKER_APP_IDin your.envfile and runyarn dev:with-companionProblems/discussion
redirect_urineeds to be frontend URI, and wilcard is not allowed. Update: I've madeappId,clientIdandapiKeyas Uppy options (not Companion) so this should be OK because people can then use their own credentials.TODO
tsconfig.json(I have just copy-pasted from google photos)tsconfig.build.json(I have just copy-pasted from google photos)google-picker.mdx(I have just copy-pasted from google photos)google-picker/README.md(I have just copy-pasted from google photos)onPickedadd the files along with any metadata needed by companion to download the files, like accessToken, clientId etc.clientId,scope,accessToken. The endpoint will callgapi.client.drive.files.get, and stream (download/upload) the file to the destination (e.g. tus/s3 etc). Need to make sure the endpoint is secure somehow in a way that it cannot be abused/exploited.this.provideris not needed in GooglePicker.ts