Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Python client "LogCommits" doesn't quote query parameters #8558

Open
caspervdw opened this issue Jan 28, 2025 · 3 comments · May be fixed by #8597
Open

[Bug]: Python client "LogCommits" doesn't quote query parameters #8558

caspervdw opened this issue Jan 28, 2025 · 3 comments · May be fixed by #8597
Assignees

Comments

@caspervdw
Copy link

What happened?

Steps to Reproduce:

  1. I uploaded a file named ";semicolon.txt"
  2. I looked at the commit log of that file through the python client (using the query parameter `objects=[";semicolon.txt"])
  3. Instead of seeing the log of the specific file, I see the log of all files in the repository

I traced the error to an issue in the OpenAPI generator. The query parameter just doesn't get property URL-quoted, leading to something like lakefs/some-path/?...objects=;semicolon.txt which is just wrong. Luckily it got fixed already some months ago: OpenAPITools/openapi-generator#20148 .

Expected behavior

No response

lakeFS version

1.24

How lakeFS is installed

docker

Affected clients

Python lakeFS client 1.48.2

Relevant log output

-

Contact details

through github is fine

@caspervdw caspervdw added bug Something isn't working contributor labels Jan 28, 2025
@caspervdw
Copy link
Author

NB: It the bug fix is present in release 7.11.0 of openapi-generator

@caspervdw
Copy link
Author

If someone can point me to where the openAPI client generator is, and how the client generation is done, I'd be happy to contribute.

@itaiad200
Copy link
Contributor

Hey @caspervdw - It's this line in the Makefile.
Thank you for your suggestion to contribute!

@N-o-Z N-o-Z removed the good first issue Good for newcomers label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants