Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display bug on Alma Linux in TMUX 3.2a #1389

Open
ConorMurphy21 opened this issue Feb 13, 2025 · 7 comments
Open

Display bug on Alma Linux in TMUX 3.2a #1389

ConorMurphy21 opened this issue Feb 13, 2025 · 7 comments
Labels

Comments

@ConorMurphy21
Copy link

lnav version
v0.12.4 installed from lnav-0.12.4-linux-musl-x86_64.zip

Describe the bug
x's on either side of logs, some of the the x's on the left are also m's and l's
Image

To Reproduce
For me just running lnav 0.12.4 on Alma Linux

I've also tried compiling from sources but since the switch to notcurses I think the configure step may be outdated. I had to get libunistring-devel and when I ran it crashed when I hit down arrow.

@tstack
Copy link
Owner

tstack commented Feb 14, 2025

Looks like the altcharset is not working, hmm…. What TERM do you have set?

tstack added a commit that referenced this issue Feb 14, 2025
@tstack
Copy link
Owner

tstack commented Feb 14, 2025

Thanks for the heads up about the crash. I managed to replicate a crash that seems to have been caused by a call to isprint() with a large value. I've pushed a change for that.

I haven't been able to replicate the display issue. But, I've just been testing with an Alma install using OrbStack on my mac. What terminal are you using?

@ConorMurphy21
Copy link
Author

Oh nice, I assumed the crash was just due to some missing dependency or smthn, glad it helped.
Ok interesting, sorry I didn't test all of the cases. This only happens inside my tmux session. $TERM = tmux-256color inside my tmux session and xterm-256color outside my tmux session. I'm running the default gnome terminal on ubuntu and then sshing into an Alma linux server, but it seems like TMUX is the issue.

@ConorMurphy21 ConorMurphy21 changed the title Display bug on Alma Linux Display bug on Alma Linux in TMUX Feb 14, 2025
@ConorMurphy21
Copy link
Author

I realized my tmux version is 3.2a so that may be why this issue is different from #1390

@ConorMurphy21
Copy link
Author

Updated to https://github.com/tstack/lnav/actions/runs/13463172327, and still seeing this display bug on tmux 3.2a

@ConorMurphy21 ConorMurphy21 changed the title Display bug on Alma Linux in TMUX Display bug on Alma Linux in TMUX 3.2a Feb 21, 2025
@tstack
Copy link
Owner

tstack commented Feb 22, 2025

Strange goings on... The smacs setting (used to switch to alt char set) for tmux-256color is ^N, which is different from xterm-256color where it's \E(0. Setting TERM to xterm-256color within tmux will get it displaying things correctly. Running an old lnav that uses ncurses works and then the new one works too...

@ConorMurphy21
Copy link
Author

ConorMurphy21 commented Feb 24, 2025

Setting TERM to xterm-256color within tmux will get it displaying things correctly.

I assume this was for debugging purposes and not an intended workaround? I don't know too much about the TERM variable but when I looked into doing this it seems like it is bad practice (I don't know if there are consequences lol)?

I guess I can just alias lnav to TERM=xterm-256color lnav for now so the scope is small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants