fix: umd config deserialization

[xusd320]

Forget to convert false config to None

Summary by CodeRabbit

• 新功能
  • 修改了反序列化功能，以处理布尔值 false 的情况，返回 Ok(None)，指示不创建 Umd 实例。

[coderabbitai]

变更概述

步骤说明

该变更修改了 crates/mako/src/config/umd.rs 文件中的 deserialize_umd 函数。新增了一个匹配分支，当反序列化的值为布尔值 false 时，函数将返回 Ok(None)，表示不创建 Umd 实例。这一变更调整了反序列化过程的控制流，为之前未处理的布尔 false 输入情况提供了特定的响应机制。

变更

文件	变更摘要
crates/mako/src/config/umd.rs	在 deserialize_umd 函数中添加布尔 false 的匹配分支，返回 Ok(None)

可能相关的 PR

• fix: umd should be import as cjs #1642: 修改 UMD 模块导入方法，与 CommonJS 标准对齐，可能与主 PR 中的 UMD 实例反序列化过程相关。
• fix: inline css config deserialize #1720: 处理内联 CSS 配置反序列化的问题，在概念上可能与主 PR 中 deserialize_umd 函数的变更有关。

建议的审阅者

• sorrycc
• stormslowly

诗歌

🐰 UMD 配置的小兔子
布尔值 false，悄悄躲避
反序列化的魔法
悄然添加新分支
代码如诗，静静流淌 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af25d70 and d463170.

📒 Files selected for processing (1)

• crates/mako/src/config/umd.rs (1 hunks)

🔇 Additional comments (1)

crates/mako/src/config/umd.rs (1)

24-24: 代码实现正确且符合预期！

新增的匹配分支正确处理了 false 值的情况，将其转换为 None。这个实现：

• 符合 Rust 的 Option 类型使用模式
• 与现有的错误处理保持一致
• 解决了 PR 描述中提到的配置反序列化问题

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This pull request addresses an issue in the UMD configuration deserialization process. Specifically, it fixes the handling of false values in the configuration by converting them to None, ensuring proper deserialization.

Changes

File	Summary
crates/mako/src/config/umd.rs	Added handling for serde_json::Value::Bool(false) to return Ok(None), fixing the deserialization of false values.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (af25d70) to head (d463170).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
crates/mako/src/config/umd.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
- Coverage   54.83%   54.83%   -0.01%     
==========================================
  Files         179      179              
  Lines       17896    17897       +1     
==========================================
  Hits         9814     9814              
- Misses       8082     8083       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.