diff --git a/app/controllers/planning_applications/review/base_controller.rb b/app/controllers/planning_applications/review/base_controller.rb index 92e3b17b2a..c577c5ab62 100644 --- a/app/controllers/planning_applications/review/base_controller.rb +++ b/app/controllers/planning_applications/review/base_controller.rb @@ -39,6 +39,10 @@ def redirect_failed_create_error(error) redirect_to planning_application_review_tasks_path(@planning_application), alert: Array.wrap(error).to_sentence end + def redirect_to_review_tasks + redirect_to planning_application_review_tasks_path(@planning_application) + end + def render_review_tasks set_planning_application_constraints set_neighbour_review diff --git a/app/controllers/planning_applications/review/cil_liability_controller.rb b/app/controllers/planning_applications/review/cil_liability_controller.rb index a2eb2ef9de..e006a7bd56 100644 --- a/app/controllers/planning_applications/review/cil_liability_controller.rb +++ b/app/controllers/planning_applications/review/cil_liability_controller.rb @@ -9,7 +9,7 @@ def update @previous_decision = @planning_application.cil_liable if @planning_application.update(cil_liability_params) record_audit_for_cil_liability! - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-cil-liability"), notice: t(".success") else render :edit end @@ -47,10 +47,6 @@ def activity_information end end - def redirect_to_review_tasks - redirect_to planning_application_review_tasks_path(@planning_application) - end - def cil_feature? @planning_application.application_type.cil? end diff --git a/app/controllers/planning_applications/review/committee_decisions_controller.rb b/app/controllers/planning_applications/review/committee_decisions_controller.rb index 07f32fc97c..c6dfff9337 100644 --- a/app/controllers/planning_applications/review/committee_decisions_controller.rb +++ b/app/controllers/planning_applications/review/committee_decisions_controller.rb @@ -15,7 +15,7 @@ def update respond_to do |format| format.html do if @committee_decision.update(committee_decision_params) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "recommendation_to_committee_section"), notice: t(".success") else flash.now[:alert] = @committee_decision.errors.messages.values.flatten.join(", ") render_review_tasks diff --git a/app/controllers/planning_applications/review/conditions_controller.rb b/app/controllers/planning_applications/review/conditions_controller.rb index 366f521fc0..c46a9dccbe 100644 --- a/app/controllers/planning_applications/review/conditions_controller.rb +++ b/app/controllers/planning_applications/review/conditions_controller.rb @@ -9,7 +9,7 @@ def update respond_to do |format| format.html do if @condition_set.update(condition_set_review_params) - redirect_to planning_application_review_tasks_path(@planning_application), + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-conditions"), notice: I18n.t("review.conditions.update.success") else flash.now[:alert] = @condition_set.errors.messages.values.flatten.join(", ") diff --git a/app/controllers/planning_applications/review/considerations/items_controller.rb b/app/controllers/planning_applications/review/considerations/items_controller.rb index b293d8eb78..4b135bfa67 100644 --- a/app/controllers/planning_applications/review/considerations/items_controller.rb +++ b/app/controllers/planning_applications/review/considerations/items_controller.rb @@ -17,7 +17,7 @@ def update respond_to do |format| format.html do if @consideration.update(consideration_params) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "considerations_section"), notice: t(".success") else render :edit end diff --git a/app/controllers/planning_applications/review/considerations_controller.rb b/app/controllers/planning_applications/review/considerations_controller.rb index 2f393f51f0..1f2982e29c 100644 --- a/app/controllers/planning_applications/review/considerations_controller.rb +++ b/app/controllers/planning_applications/review/considerations_controller.rb @@ -17,7 +17,7 @@ def update respond_to do |format| format.html do if @review.update(review_params) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-considerations"), notice: t(".success") else flash.now[:alert] = @review.errors.messages.values.flatten.join(", ") render_review_tasks @@ -45,10 +45,6 @@ def review_params .permit(:action, :comment, :review_status) .merge(reviewer: current_user, reviewed_at: Time.current) end - - def redirect_to_review_tasks - redirect_to planning_application_review_tasks_path(@planning_application) - end end end end diff --git a/app/controllers/planning_applications/review/heads_of_terms_controller.rb b/app/controllers/planning_applications/review/heads_of_terms_controller.rb index 990d3b820a..ff095514d0 100644 --- a/app/controllers/planning_applications/review/heads_of_terms_controller.rb +++ b/app/controllers/planning_applications/review/heads_of_terms_controller.rb @@ -7,7 +7,7 @@ def update respond_to do |format| format.html do if heads_of_term.update(review_params) - redirect_to planning_application_review_tasks_path(@planning_application), + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-heads-of-terms"), notice: I18n.t("review.heads_of_terms.update.success") else flash.now[:alert] = heads_of_term.errors.messages.values.flatten.join(", ") diff --git a/app/controllers/planning_applications/review/immunity_details_controller.rb b/app/controllers/planning_applications/review/immunity_details_controller.rb index 343db014db..71ad9fc440 100644 --- a/app/controllers/planning_applications/review/immunity_details_controller.rb +++ b/app/controllers/planning_applications/review/immunity_details_controller.rb @@ -16,7 +16,7 @@ def update respond_to do |format| format.html do if @review_immunity_detail.update(review_immunity_detail_params) - redirect_to planning_application_review_tasks_path(@planning_application), + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-immunity-details"), notice: I18n.t("planning_applications.review..immunity_details.successfully_updated") else flash.now[:alert] = @review_immunity_detail.errors.messages.values.flatten.join(", ") diff --git a/app/controllers/planning_applications/review/immunity_enforcements_controller.rb b/app/controllers/planning_applications/review/immunity_enforcements_controller.rb index c59eacce68..aa57356a41 100644 --- a/app/controllers/planning_applications/review/immunity_enforcements_controller.rb +++ b/app/controllers/planning_applications/review/immunity_enforcements_controller.rb @@ -13,7 +13,7 @@ def update respond_to do |format| format.html do if @review_immunity_detail.update(review_immunity_detail_params) - redirect_to planning_application_review_tasks_path(@planning_application), + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-immunity-enforcements"), notice: I18n.t("review_immunity_enforcements.successfully_updated") else flash.now[:alert] = @review_immunity_detail.errors.messages.values.flatten.join(", ") diff --git a/app/controllers/planning_applications/review/informatives/items_controller.rb b/app/controllers/planning_applications/review/informatives/items_controller.rb index 23103358c6..96ddb59e0b 100644 --- a/app/controllers/planning_applications/review/informatives/items_controller.rb +++ b/app/controllers/planning_applications/review/informatives/items_controller.rb @@ -17,7 +17,7 @@ def update respond_to do |format| format.html do if @informative.update(informative_params) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-informatives"), notice: t(".success") else render :edit end diff --git a/app/controllers/planning_applications/review/informatives_controller.rb b/app/controllers/planning_applications/review/informatives_controller.rb index a68cdb8c7e..9f72afbc88 100644 --- a/app/controllers/planning_applications/review/informatives_controller.rb +++ b/app/controllers/planning_applications/review/informatives_controller.rb @@ -19,7 +19,7 @@ def update respond_to do |format| format.html do if @review.update(review_params) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-informatives"), notice: t(".success") else flash.now[:alert] = @review.errors.messages.values.flatten.join(", ") render_review_tasks @@ -48,10 +48,6 @@ def review_params .merge(reviewer: current_user, reviewed_at: Time.current) end - def redirect_to_review_tasks - redirect_to planning_application_review_tasks_path(@planning_application) - end - def informatives_not_started? @review.not_started? end diff --git a/app/controllers/planning_applications/review/neighbour_responses_controller.rb b/app/controllers/planning_applications/review/neighbour_responses_controller.rb index 8db1ecf6c4..67f8f761c2 100644 --- a/app/controllers/planning_applications/review/neighbour_responses_controller.rb +++ b/app/controllers/planning_applications/review/neighbour_responses_controller.rb @@ -12,7 +12,7 @@ def update respond_to do |format| format.html do if @neighbour_review.update(review_params) && @consultation.update(status: consultation_status) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-neighbour-responses"), notice: t(".success") else error = @neighbour_review.errors.group_by_attribute.transform_values { |errors| errors.map(&:full_message) }.values.flatten redirect_failed_create_error(error) @@ -27,7 +27,7 @@ def create respond_to do |format| format.html do if @neighbour_review.save && @consultation.update(status: consultation_status) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-neighbour-responses"), notice: t(".success") else error = @neighbour_review.errors.group_by_attribute.transform_values { |errors| errors.map(&:full_message) }.values.flatten redirect_failed_create_error(error) diff --git a/app/controllers/planning_applications/review/permitted_development_rights_controller.rb b/app/controllers/planning_applications/review/permitted_development_rights_controller.rb index 18442d1da0..72543f9823 100644 --- a/app/controllers/planning_applications/review/permitted_development_rights_controller.rb +++ b/app/controllers/planning_applications/review/permitted_development_rights_controller.rb @@ -14,7 +14,7 @@ def update respond_to do |format| format.html do if @permitted_development_right.update(permitted_development_right_params) - redirect_to planning_application_review_tasks_path(@planning_application), + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-permitted-development-rights"), notice: I18n.t("permitted_development_rights.successfully_updated") else flash.now[:alert] = @permitted_development_right.errors.messages.values.flatten.join(", ") diff --git a/app/controllers/planning_applications/review/policy_areas/policy_classes_controller.rb b/app/controllers/planning_applications/review/policy_areas/policy_classes_controller.rb index c5c5b4156b..2469a78e2d 100644 --- a/app/controllers/planning_applications/review/policy_areas/policy_classes_controller.rb +++ b/app/controllers/planning_applications/review/policy_areas/policy_classes_controller.rb @@ -30,7 +30,7 @@ def update @form.update(policy_section_status_params) if @planning_application_policy_class.update_review(review_params) - redirect_to planning_application_review_policy_areas_policy_classes_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_policy_areas_policy_classes_path(@planning_application, anchor: "review-policy-classes"), notice: t(".success") else render :edit end diff --git a/app/controllers/planning_applications/review/pre_commencement_conditions_controller.rb b/app/controllers/planning_applications/review/pre_commencement_conditions_controller.rb index f0d1c5869b..5a05c1d778 100644 --- a/app/controllers/planning_applications/review/pre_commencement_conditions_controller.rb +++ b/app/controllers/planning_applications/review/pre_commencement_conditions_controller.rb @@ -14,7 +14,7 @@ def update respond_to do |format| format.html do if @pre_commencement_condition_set.update(review_params) - redirect_to planning_application_review_tasks_path(@planning_application), + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-pre-commencement-conditions"), notice: I18n.t("review.conditions.update.success") else flash.now[:alert] = @pre_commencement_condition_set.errors.messages.values.flatten.join(", ") diff --git a/app/controllers/planning_applications/review/publicities_controller.rb b/app/controllers/planning_applications/review/publicities_controller.rb index fd4b6261e4..0c4e2fe90c 100644 --- a/app/controllers/planning_applications/review/publicities_controller.rb +++ b/app/controllers/planning_applications/review/publicities_controller.rb @@ -12,7 +12,7 @@ def update respond_to do |format| format.html do if @assessment_detail.update(assessment_detail_params) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-publicities"), notice: t(".success") else flash.now[:alert] = @assessment_detail.errors.messages.values.flatten.join(", ") render_review_tasks @@ -27,7 +27,7 @@ def create respond_to do |format| format.html do if @assessment_detail.save - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "review-publicities"), notice: t(".success") else flash.now[:alert] = @assessment_detail.errors.messages.values.flatten.join(", ") render_review_tasks diff --git a/app/controllers/planning_applications/review/recommendations_controller.rb b/app/controllers/planning_applications/review/recommendations_controller.rb index 51dcd73906..cbee421330 100644 --- a/app/controllers/planning_applications/review/recommendations_controller.rb +++ b/app/controllers/planning_applications/review/recommendations_controller.rb @@ -28,7 +28,7 @@ def create ) if @recommendation.save_and_submit(recommendation_form_params) - redirect_to planning_application_review_tasks_path(@planning_application), notice: t(".success") + redirect_to planning_application_review_tasks_path(@planning_application, anchor: "recommendation_to_committee_section"), notice: t(".success") else render :new end diff --git a/app/views/planning_applications/review/policy_areas/policy_classes/index.html.erb b/app/views/planning_applications/review/policy_areas/policy_classes/index.html.erb index 472b253066..0a5f0ed3f2 100644 --- a/app/views/planning_applications/review/policy_areas/policy_classes/index.html.erb +++ b/app/views/planning_applications/review/policy_areas/policy_classes/index.html.erb @@ -14,7 +14,7 @@ <%= render "shared/dates_and_assignment_header" %> -