Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code-style #140

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Fix code-style #140

merged 1 commit into from
Jun 18, 2021

Conversation

UnPolinomio
Copy link
Contributor

Hey, there.

Currently npm test throws the following error:

test/index.js:4:9
✖ 4:9 Missing file extension for "./core" import/extensions
✖ 5:9 Missing file extension for "./freeze" import/extensions
...
13 errors

This pull request fixes those errors and now all tests pass.
Hope you find this useful.

@wooorm wooorm changed the title Add file extension in require() Fix code-style Jun 18, 2021
@wooorm wooorm merged commit 115898a into unifiedjs:main Jun 18, 2021
@wooorm
Copy link
Member

wooorm commented Jun 18, 2021

Thanks @UnPolinomio, nice catch!

@wooorm wooorm added 🏗 area/tools This affects tooling 🏡 area/internal This affects the hidden internals 💪 phase/solved Post is done 🦋 type/enhancement This is great to have labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🏡 area/internal This affects the hidden internals 🏗 area/tools This affects tooling 💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UnPolinomio @wooorm @ChristianMurphy