Fix to set vfile.value if a vfile@5 is given
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfile@5 changed from the `contents` to the `value field. Given that not all of the ecosystem has updated yet, and that some version mismatches will occur for the foreseeable future, setting both `contents` *and* `value` in those cases will hopefully alleviate some of the struggles with updating. Related to remarkjs/remark-frontmatter#16.
This comment has been minimized.
This comment has been minimized.
ChristianMurphy
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
vfile@5 changed from the
contentsto thevalue field. Given that not all of the ecosystem has updated yet, and that some version mismatches will occur for the foreseeable future, setting bothcontents*and*value` in those cases will hopefully alleviatesome of the struggles with updating.
Related to remarkjs/remark-frontmatter#16.