Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types to support booleans #147

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Fix types to support booleans #147

merged 1 commit into from
Jul 6, 2021

Conversation

ChristianMurphy
Copy link
Member

… Plugin settings

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Follow up to #145 (comment)
Tests for boolean support should still pass

unified/types/unified-tests.ts

Lines 80 to 85 in 5167c49

processor.use(plugin, true)
processor.use(plugin, false)
processor.use([
[plugin, true],
[plugin, false]
])

@ChristianMurphy ChristianMurphy added the ☂️ area/types This affects typings label Jul 6, 2021
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 6, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@wooorm wooorm changed the title refactor(types): support boolean enable for plugin, without modifying… Fix types to support booleans Jul 6, 2021
@wooorm wooorm merged commit b8fe5ec into unifiedjs:main Jul 6, 2021
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 💪 phase/solved Post is done label Jul 6, 2021
@wooorm
Copy link
Member

wooorm commented Jul 6, 2021

nice!

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 6, 2021
@ChristianMurphy ChristianMurphy mentioned this pull request Jul 6, 2021
Merged
5 tasks
@ChristianMurphy ChristianMurphy deleted the types-refactor branch July 6, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristianMurphy @codecov-commenter @wooorm