Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix next in types of transformer signature #149

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Fix next in types of transformer signature #149

merged 2 commits into from
Jul 6, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Jul 6, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

  • next can also be called w/o parameters, to just continue on
  • next returns void (return next() is fine in a transformer)

@wooorm wooorm added the ☂️ area/types This affects typings label Jul 6, 2021
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 6, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
ChristianMurphy
ChristianMurphy approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wooorm!

@wooorm wooorm changed the title types: fix next in transformer signature Fix next in types of transformer signature Jul 6, 2021
@wooorm wooorm merged commit 350ed9d into main Jul 6, 2021
@wooorm wooorm deleted the transformer-next branch July 6, 2021 20:24
@wooorm wooorm added the 💪 phase/solved Post is done label Jul 6, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wooorm @codecov-commenter @ChristianMurphy