Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canary workflow #182

Merged
merged 2 commits into from
Jan 2, 2022
Merged

Add canary workflow #182

merged 2 commits into from
Jan 2, 2022

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Follow up to: unifiedjs/ideas#7

Unified is a large and highly connected community of packages.
Changes to any package could have impact downstream packages.
Currently anticipating impact is a purely manual process.

It could be helpful to use downstream packages, which themselves have comprehensive test suites, to help automatically detect what changes may be breaking or have unintended impacts.

@ChristianMurphy ChristianMurphy added the 🕸️ area/tests This affects tests label Dec 30, 2021
@ChristianMurphy ChristianMurphy requested a review from a team December 30, 2021 20:18
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 30, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy force-pushed the canary branch 2 times, most recently from 6f1732c to 320f32a Compare December 30, 2021 20:22
@ChristianMurphy ChristianMurphy mentioned this pull request Dec 30, 2021
Merged
5 tasks
@ChristianMurphy ChristianMurphy mentioned this pull request Dec 30, 2021
Merged
5 tasks
@ChristianMurphy

This comment has been minimized.

Sign in to view
@ChristianMurphy

This comment has been minimized.

Sign in to view
wooorm
wooorm reviewed Dec 31, 2021
View reviewed changes
@wooorm wooorm changed the title Canary test workflow, checks that key downstream packages still build Add canary workflow Jan 2, 2022
@wooorm wooorm merged commit b0821ee into unifiedjs:main Jan 2, 2022
@wooorm wooorm added the 💪 phase/solved Post is done label Jan 2, 2022
@wooorm
Copy link
Member

wooorm commented Jan 2, 2022

sweet!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🕸️ area/tests This affects tests 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristianMurphy @codecov-commenter @wooorm