Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from js-yaml to yaml #33

Open
pi0 opened this issue Oct 6, 2024 · 1 comment
Open

switch from js-yaml to yaml #33

pi0 opened this issue Oct 6, 2024 · 1 comment
Labels
discussion enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Oct 6, 2024

Context: Pointed out by @remcohaszing in x npm:yaml is much more spec-compliant than npm:js-yaml

The main reason for choosing js-yaml was that it is ~10x faster and it is important for recurring reads (especially for cases like markdown front matter) but if spec compliant is better I think switch would make sense.

@pi0 pi0 added enhancement New feature or request discussion labels Oct 6, 2024
@remcohaszing
Copy link

You can see some reasoning in https://github.com/orgs/remarkjs/discussions/1006#discussioncomment-2955255. Also js-yaml hasn’t been updated for a while. It appears to be abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants