Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add orChar/from chain for charIn/charNotIn #399

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add orChar/from chain for charIn/charNotIn #399

wants to merge 3 commits into from

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 4, 2024 •
edited
Loading

🔗 Linked issue

resolves #397

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds an implementation for creating custom ranges like [abcA-Z].

TODO:

  • add converter implementation to convert to this syntax
  • validate/review API

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magic-regexp-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:51pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Diagnostics Comparison:

Click to expand
Metric Previous New Status
Files 352 352 ± (0.00%)
Lines 136176 136227 ▲ (+0.04%)
Identifiers 144200 144386 ▲ (+0.13%)
Symbols 246224 248193 ▲ (+0.79%)
Types 50363 52292 ▲ (+3.69%)
Instantiations 605012 613876 ▲ (+1.44%)
Memory used 276359K 288249K ▲ (+4.12%)
I/O read 0.02s 0.02s ± (0.00%)
I/O write 0s 0s ± (0.00%)
Parse time 0.87s 0.87s ± (0.00%)
Bind time 0.35s 0.35s ± (0.00%)
Check time 1.94s 2.04s ± (+4.90%)
Emit time 0.09s 0.08s ± (-12.50%)
Total time 3.24s 3.33s ± (+2.70%)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #399 will not alter performance

Comparing feat/or-char-from (4091f08) with main (b06c4e9)

Summary

✅ 6 untouched benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Diagnostics Comparison:

Click to expand
Metric Previous New Status
Files 352 352 ± (0.00%)
Lines 136176 136227 ▲ (+0.04%)
Identifiers 144200 144387 ▲ (+0.13%)
Symbols 246224 248193 ▲ (+0.79%)
Types 50363 52292 ▲ (+3.69%)
Instantiations 605012 613876 ▲ (+1.44%)
Memory used 273822K 282845K ▲ (+3.19%)
I/O read 0.03s 0.02s ▼ (-50.00%)
I/O write 0s 0s ± (0.00%)
Parse time 1.03s 0.89s ± (-15.73%)
Bind time 0.39s 0.35s ± (-11.43%)
Check time 2.22s 2.06s ± (-7.77%)
Emit time 0.09s 0.09s ± (0.00%)
Total time 3.73s 3.38s ▼ (-10.36%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didavid61202 didavid61202 Awaiting requested review from didavid61202

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to convert regex with custom character set to magic-regexp
1 participant
@danielroe