Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate information in Timeline #3437

Open
1 task done
mattisking opened this issue Nov 6, 2024 · 4 comments
Open
1 task done

Add certificate information in Timeline #3437

mattisking opened this issue Nov 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@mattisking
Copy link

I have checked the following:

  • I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add

The Timeline feature is fine for most needs, but it falls short of Postman's Developer Console. If I'm testing something around security, let's say your organization uses MTLS, and your calls keep coming back with a 403 (or 401), the first thing I check is to verify that my certificate was sent and in more complex collections, that I sent the right certificate.

I'd like to see the certificate sent in the request to verify the certificate I configured was sent (or it's the one I expected it to be).

Mockups or Images of the feature

image001
This is the image from Postman, Developer Console. If a Client Certificate was sent, it will be in the image with the ability to view the file sent, as well as any other cert information. I would expect to see this in the regular Timeline, not in the Bruno Gold Edition Console which is more about Bruno itself.

I looked at seeing how difficult this would be to do since you pass these neat request and response objects all over the place, but the request doesn't include the certificate information. I don't have much Electron experience, but it appears you are using an ipc call where electron itself is making the match based on the collection configuration and that simply isn't stored in the object. What if you moved that logic back into the site code and stored it in the request, allowing that to be available in the Timeline page (and then electron would just use the cert you matched internally. That, or perhaps attach the certificate selected in the electron app to the response object before passing it back.

@mattisking mattisking added the enhancement New feature or request label Nov 6, 2024
@Its-treason
Copy link
Member

Its-treason commented Nov 6, 2024

If you need this feature now you can checkout my fork: https://github.com/Its-treason/bruno/releases/tag/nightly It has this feature and is fully compatible with Bruno.

@mattisking
Copy link
Author

You've got quite the series of updates. Thanks. Are some of these changes coming back here? I have no experience with pnpm but that was far faster.

@Its-treason
Copy link
Member

Its-treason commented Nov 8, 2024

You've got quite the series of updates. Thanks. Are some of these changes coming back here?

Yes, I have opened a few pull requests, so some fixes will hopefully get merged. I don't expect other things like the new Timeline to be merged, because that would take significant changes in Bruno.

@mattisking
Copy link
Author

I dunno. Moving that into your Bruno-core and rewriting the request mechanism is exactly what I saw as the thing to do as well. Some of the other things which I thought were quite nice (modals) would probably be tougher but this is exactly what I was looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants