-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump WebUI versions for 5.1.0 Beta1 and Uyuni 2025.03 #9855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if you also checked the schemas, you didn't mention this in the description
web/spacewalk-web.changes.raul.bump_osversion_beta_51_and_uyuni
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the thing mentioned by @deneb-alpha, LGTM.
FMPOV you can get rid of the changelog entry, mark the checkbox and the merge.
|
Remove unneeded changelog
8629b2e
to
2933971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
What does this PR change?
Change WebUI versions for MLM to 5.1.0 Beta1 and 2025.03 for Uyuni.
Also checked the schema upgrade paths:
5.1.3
forschema/spacewalk
,schema/spacewalk/upgrade/susemanager-schema-5.1.3-to-susemanager-schema-5.1.4/
exists and has content -> no action needed5.1.3
forschema/reportdb
, no migration directory but reportdb package does NOT report any changes intito-wrapper -c
GUI diff
Before: 5.1.0 Alpha2 or Uyuni 2024.12
After: 5.1.0 Beta1 or Uyuni 2025.03
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: already covered
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/26544
https://github.com/SUSE/spacewalk/issues/26151
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!