Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WebUI versions for 5.1.0 Beta1 and Uyuni 2025.03 #9855

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

raulillo82
Copy link
Contributor

@raulillo82 raulillo82 commented Feb 26, 2025

What does this PR change?

Change WebUI versions for MLM to 5.1.0 Beta1 and 2025.03 for Uyuni.

Also checked the schema upgrade paths:

  • Schema version is 5.1.3 for schema/spacewalk, schema/spacewalk/upgrade/susemanager-schema-5.1.3-to-susemanager-schema-5.1.4/ exists and has content -> no action needed
  • reportdb version is 5.1.3 for schema/reportdb, no migration directory but reportdb package does NOT report any changes in tito-wrapper -c

GUI diff

Before: 5.1.0 Alpha2 or Uyuni 2024.12

After: 5.1.0 Beta1 or Uyuni 2025.03

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: already covered

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/26544
https://github.com/SUSE/spacewalk/issues/26151

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if you also checked the schemas, you didn't mention this in the description

juliogonzalez
juliogonzalez previously approved these changes Feb 26, 2025
Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the thing mentioned by @deneb-alpha, LGTM.

FMPOV you can get rid of the changelog entry, mark the checkbox and the merge.

@raulillo82
Copy link
Contributor Author

raulillo82 commented Feb 26, 2025

  • Schema version is 5.1.3 for schema/spacewalk, schema/spacewalk/upgrade/susemanager-schema-5.1.3-to-susemanager-schema-5.1.4/ exists and has content -> no action needed
  • reportdb version is 5.1.3 for schema/reportdb, no migration directory but reportdb package does NOT report any changes in tito-wrapper -c

@raulillo82 raulillo82 force-pushed the bump_osversion_beta_51_and_uyuni branch from 8629b2e to 2933971 Compare February 26, 2025 13:34
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@raulillo82 raulillo82 merged commit 2f6e19a into master Feb 26, 2025
23 of 26 checks passed
@raulillo82 raulillo82 deleted the bump_osversion_beta_51_and_uyuni branch February 26, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants