{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":739603595,"defaultBranch":"master","name":"keyrings.codeartifact","ownerLogin":"viaduct-ai","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-01-06T01:27:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/47343721?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719208187.0","currentOid":""},"activityList":{"items":[{"before":"9d50b8c915134bf12ac93e9adb81182f1cdd1192","after":null,"ref":"refs/heads/fix-repo-name-parsing","pushedAt":"2024-06-24T05:49:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"tadeboro","name":"Tadej Borovšak","path":"/tadeboro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/70951?s=80&v=4"}},{"before":null,"after":"9d50b8c915134bf12ac93e9adb81182f1cdd1192","ref":"refs/heads/fix-repo-name-parsing","pushedAt":"2024-06-21T21:33:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tadeboro","name":"Tadej Borovšak","path":"/tadeboro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/70951?s=80&v=4"},"commit":{"message":"fix: Update package name extraction from codeartifact path\n\nWhen we added support for multiple configuration sections in commit\n46e83fe03a305da673b20e7e1da6a2a93c8b6b6d, we inadvertently broke the\npath parsing logic. A typical error would look something similar to\nthis:\n\n    too many values to unpack (expected 3)\n    at ~/path/to/keyrings/codeartifact.py:151 in get_password\n      150│ # Use the second and third parts as repository type and name.\n    → 151│ _, repository_type, repository_name = parts\n\nThe core of the problem was that our code assumed that codeartifact\npaths look like /pypi/repo-name, but this assumption is false. Normally,\nwhat we see is actually /pypi/repo-name/simple/ as documented in the AWS\ndocumentation.\n\nWe also moved away from using PurePath to parse our paths. PurePath is\nOS-dependent and behaves differently based on the platform we currently\nrun our Python interpretea on, but this is now what we want when parsing\npaths in urls. Since valid codeartifact paths have very little variety\nin them, we oped to parse them using a relatively simple regular\nexpression.\n\nOur regular expression for validating url paths is a bit less strict\nthan what is described in AWS docs. The codeartifact docs state that all\nurls need to end with a /simple/ suffix or things will not work. But in\npractice, paths without a trailing / also work fine as redirect to\n/-suffixed path as required by PEP 503.","shortMessageHtmlLink":"fix: Update package name extraction from codeartifact path"}},{"before":"af87af6bba121ffd1564ecd26bfea62360a26ffc","after":"46e83fe03a305da673b20e7e1da6a2a93c8b6b6d","ref":"refs/heads/master","pushedAt":"2024-06-21T15:58:22.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"tadeboro","name":"Tadej Borovšak","path":"/tadeboro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/70951?s=80&v=4"},"commit":{"message":"Implement support for multiple configuration sections.","shortMessageHtmlLink":"Implement support for multiple configuration sections."}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEbSW97QA","startCursor":null,"endCursor":null}},"title":"Activity · viaduct-ai/keyrings.codeartifact"}