Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a safe stringify helper in place of JSON.stringify #7036

Open
robwalch opened this issue Feb 19, 2025 · 1 comment · May be fixed by #7045
Open

Use a safe stringify helper in place of JSON.stringify #7036

robwalch opened this issue Feb 19, 2025 · 1 comment · May be fixed by #7045
Milestone
1.6.0

Comments

@robwalch
Copy link
Collaborator

Log lines that stringify objects with cyclical references throw. These references can come from external objects like the media element that have addition properties on them. Example #7008.
@robwalch robwalch added this to the 1.6.0 milestone Feb 19, 2025
@robwalch robwalch mentioned this issue Feb 19, 2025
Merged
3 tasks
@robwalch
Copy link
Collaborator Author

Merged:

robwalch added a commit that referenced this issue Feb 21, 2025
@robwalch
Replace JSON.stringify with safe stringify module
560a149 
Resolves #7036 (Follow up to #7037)
@robwalch robwalch linked a pull request Feb 21, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
HLS.js Release Planning and Backlog
Status: Top priorities
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Replace JSON.stringify with safe stringify module video-dev/hls.js
1 participant
@robwalch