Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with nra-assist.com #2

Open
gdgenchev opened this issue Jul 21, 2024 · 0 comments
Open

Integration with nra-assist.com #2

gdgenchev opened this issue Jul 21, 2024 · 0 comments

Comments

@gdgenchev
Copy link

gdgenchev commented Jul 21, 2024

Hello,

Just to let you know that I have integrated https://nra-assist.com with nap-autopilot! You can close this issue right away. I am not sure why I am writing this here, but this is what I was looking at the last hours :D.

Some points related to the integration:

  1. In my case I do not distinguish between ETFs and Shares, because after conducting a lot of research, it turned out that it is alright to declare them as shares if you like (or you can not declare them at all I think) and actually declaring them as "Дялове" is not correct. You can see some thoughts on the website Home -> Declaration section.

  2. Also, I have integrated the sales, but you should mention somewhere that sells on the regulated market need to be declared in App 13 instead of App 5. This is a reason I have not integrated nra-assist sales with nra xml import, as it is impossible or very hard to say which sale where to be declared App 5 or 13 and ofc the other reason is that they just discontinued the xml import..

  3. Also, I saw some possibly strange decisions for some default values in the declaration that are a bit different from my default decisions in the nra xml i.e. I think it was about the dividend tax type.

A point on the script code itself:

  1. As a Java programmer, I have some concers on the length of your script - 3k lines of code in a single file, which might be a maintainability nightmare. Also, a few months ago I tried running it and had to do some changes to the scripts, so they would start on Windows. But, but..., actually I stopped caring today and got some inspiration to work on my project and got some really nice tempo and decided to just integrate nap-autopilot in the backend as well. If someone can make use of this integration, I would not stop him and I will say a few good words for nap-autopilot and the integration on the website :)

When you have some time and inspiration you may try and check how it goes by directly testing in production (heh). If everything is alright, I would also be happy if you drop some lines somewhere for my project as well ;)

Thank you & Regards,
Georgi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant