Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The content of the markdown file cannot be displayed completely. #4194

Closed
4 tasks done
xxf24 opened this issue Sep 11, 2024 · 1 comment
Closed
4 tasks done

The content of the markdown file cannot be displayed completely. #4194

xxf24 opened this issue Sep 11, 2024 · 1 comment
Labels
bug Something isn't working upstream Related to the dependencies

Comments

@xxf24
Copy link

xxf24 commented Sep 11, 2024

Describe the bug

Recently, after upgrading Vue to 3.5.x, I found that the iframe tags in markdown files may cause the content of the markdown files to be missing.

Here's a minimal replication: https://stackblitz.com/edit/vite-gggmth?file=docs%2Findex.md

Reproduction

# VitePress 💙 StackBlitz

Hi there :wave: This is a demo running VitePress within your **browser tab**!

<iframe width="560" height="315" src="https://www.youtube.com/embed/CJ9Ya4g-Nj8?si=uFxwopP_zoEOW-J6" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>

## Powered by Vite

...other contents

Above is my markdown content, But after rendering, h1 section is missing.

image

Expected behavior

Even if the iframe fails to load, it doesn't affect the h1 section

image

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    vitepress: latest => 1.3.4

Additional context

No response

Validations

@xxf24 xxf24 added the bug: pending triage Maybe a bug, waiting for confirmation label Sep 11, 2024
@brc-dd brc-dd added bug Something isn't working and removed bug: pending triage Maybe a bug, waiting for confirmation labels Sep 13, 2024
@brc-dd
Copy link
Member

brc-dd commented Sep 16, 2024

This seems to be fixed now with latest vue?

I'm not sure but some fix in 3.5.5 resolved this.

@brc-dd brc-dd closed this as completed Sep 16, 2024
@brc-dd brc-dd added the upstream Related to the dependencies label Sep 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working upstream Related to the dependencies
Projects
None yet
Development

No branches or pull requests

2 participants