[css-round-display-1] Update viewport-fit to property of viewport meta element #11757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a element. The @Viewport rule was removed in favor of using viewport meta properties. This updates viewport-fit to follow this change.
flackr
commented
Feb 20, 2025
| @@ -245,7 +237,7 @@ Because of this, depending on the size of the viewport, some part of the page ma | |||
| </figcaption> | |||
| </figure> | |||
|
|
|||
| 'viewport-fit' can control the clipped area by setting the size of the visual viewport. | |||
| 'viewport-fit' can control the clipped area by setting the size of the layout viewport. | |||
|
|
|||
| Values have the following meanings: | |||
There was a problem hiding this comment.
In our implementation there seems to be no difference between auto and contain, it may make sense to just remove the auto value and specify the default behavior is contain, though I tried to keep this PR to a strictly editorial update of following the change in the css-viewport spec.
|
@tabatkins can you take a look? This is updating the spec to match the way browsers are implementing viewport-fit - on the meta element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@viewportrule was removed[1] in favor of using viewport meta properties. This updates viewport-fit to follow this change.[1] https://www.w3.org/TR/css-viewport-1/#since-the-29-march-2016-working-draft