Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the sRGB EOTF gamma in the HDR compositing example (Annex Q.1) #1072

Merged
merged 2 commits into from
May 29, 2019
Merged

Correct the sRGB EOTF gamma in the HDR compositing example (Annex Q.1) #1072

merged 2 commits into from
May 29, 2019

Conversation

palemieux
Copy link
Contributor

Closes #1070

@palemieux palemieux requested a review from cconcolato May 2, 2019 15:31
@palemieux palemieux self-assigned this May 2, 2019
@palemieux palemieux mentioned this pull request May 2, 2019
Open
nigelmegitt
nigelmegitt approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skynavga
skynavga requested changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@skynavga skynavga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reword so as to avoid repeating the phrase "is intended to illustrate" twice (in both the introductory paragraph and the note)?

@palemieux
Copy link
Contributor Author

Per #1070 (comment), I recommend withholding the PR until progress is made on the ticket.

@skynavga skynavga added this to the 2ED-FPWD milestone May 25, 2019
@skynavga skynavga merged commit baaf935 into master May 29, 2019
@skynavga skynavga deleted the issue-1070-sRGB-gamma-value branch May 29, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skynavga skynavga skynavga approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

@cconcolato cconcolato Awaiting requested review from cconcolato

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
2ED-CR
Development

Successfully merging this pull request may close these issues.

Gamma approximation in luminance gain.
3 participants
@palemieux @skynavga @nigelmegitt