Fix imports to avoid client-side errors #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wasp-lang#370 Organize `server/utils.ts` functions to avoid client-side imports. * Add `template/app/src/server/envUtils.ts` to contain the `requireNodeEnvVar` function. * Remove `requireNodeEnvVar` function from `template/app/src/server/utils.ts`. * Update imports of `requireNodeEnvVar` in `template/app/src/payment/plans.ts`, `template/app/src/payment/lemonSqueezy/paymentProcessor.ts`, `template/app/src/payment/stripe/paymentProcessor.ts`, `template/app/src/payment/stripe/stripeClient.ts`, `template/app/src/payment/lemonSqueezy/webhook.ts`, and `template/app/src/payment/stripe/webhook.ts` to import from `template/app/src/server/envUtils.ts`.
|
Thank you for your effort! Right direction for this problem is reorganizing the code to prevent accidental imports of server code by transitive imports. We would love to accept a solution like that, where it is also obvious that careful thought was put into it. Right now, what you submitted seems more simplistic and likely LLM driven, without deeper understanding of the issue at hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
Organize
server/utils.tsfunctions to avoid client-side imports.template/app/src/server/envUtils.tsto contain therequireNodeEnvVarfunction.requireNodeEnvVarfunction fromtemplate/app/src/server/utils.ts.requireNodeEnvVarintemplate/app/src/payment/plans.ts,template/app/src/payment/lemonSqueezy/paymentProcessor.ts,template/app/src/payment/stripe/paymentProcessor.ts,template/app/src/payment/stripe/stripeClient.ts,template/app/src/payment/lemonSqueezy/webhook.ts, andtemplate/app/src/payment/stripe/webhook.tsto import fromtemplate/app/src/server/envUtils.ts.