Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve common cmake files and enable libraries UT #592

Closed
TomasTurina opened this issue Feb 11, 2025 · 2 comments · Fixed by #589
Closed

Improve common cmake files and enable libraries UT #592

TomasTurina opened this issue Feb 11, 2025 · 2 comments · Fixed by #589
Assignees
@TomasTurina
Labels
level/task Task issue module/agent type/enhancement Enhancement issue

Comments

@TomasTurina
Copy link
Member

Description

The common libraries located in the src/common directory have many things that need to be improved:

  • Many of them are not linked correctly by the libraries that use them.
  • Many of them have targets that are not being used anywhere.
  • Some are using incorrect cmake versions.
  • UT are not running on most of the common libraries.

These problems should be addressed as part of this issue.
@TomasTurina TomasTurina self-assigned this Feb 11, 2025
@TomasTurina TomasTurina linked a pull request Feb 11, 2025 that will close this issue
Some common libraries improvements #589
Merged
8 tasks
@wazuhci wazuhci moved this to In progress in XDR+SIEM/Release 5.0.0 Feb 11, 2025
@TomasTurina
Copy link
Member Author

Update

Common libraries now are executing their UT. Missing some improvements and fixes in Windows and macOS executions.

@wazuhci wazuhci moved this from In progress to In review in XDR+SIEM/Release 5.0.0 Feb 14, 2025
@TomasTurina
Copy link
Member Author

Update

PR ready for review.

@wazuhci wazuhci moved this from In review to Done in XDR+SIEM/Release 5.0.0 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomasTurina TomasTurina

Labels
level/task Task issue module/agent type/enhancement Enhancement issue
Projects
XDR+SIEM/Release 5.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some common libraries improvements wazuh/wazuh-agent
1 participant
@TomasTurina