Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface test type in the UI #211

Closed
lukebjerring opened this issue May 31, 2018 · 6 comments
Closed

Surface test type in the UI #211

lukebjerring opened this issue May 31, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@lukebjerring
Copy link
Contributor

Related to #56

After surfacing all tests in the manifest, the UI is left with some 'holes' for manual tests. This issue covers revision of the UI to better reflect what was and was not run, as well as what the test types are (e.g. reftest, manual, etc)

@lukebjerring
Copy link
Contributor Author

@foolip said:

Mockup for directory with no tests run, accname here:
screenshot from 2018-05-31 15-24-09

For the denominator, the choice will be to either include unrun tests or not. Thinking about it, I think we probably should. So accname should ideally say "0 / 80" or something.

@lukebjerring lukebjerring self-assigned this May 31, 2018
@foolip foolip added the enhancement New feature or request label Aug 17, 2018
@lukebjerring
Copy link
Contributor Author

@foolip - I'm thinking some tiny unicode or icons for the test types. Any knowledge of existing icons?

@foolip
Copy link
Member

foolip commented Jan 8, 2019

If you just want an icon for manual tests and nothing to distinguish the other 3 types, then something with a hand might work. But I can't find a suitable unicode hand.

@lukebjerring
Copy link
Contributor Author

@foolip
Copy link
Member

foolip commented Jan 8, 2019

Yes, that's great! https://material.io/tools/icons/?icon=rowing&style=baseline would be very funny, but I don't get why that icon even exists :)

@lukebjerring
Copy link
Contributor Author

This is done, and can optionally be enabled in /flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants