-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/api/run
should give an error when params are not specific enough
#285
Comments
In fact, we might as well get rid of this endpoint. IMHO it's a bit redundant with |
The behaviour of selecting the most recent run that matches the |
Then is it same as |
No; that:
|
The use of Our current status, now that |
Logs show that at least one person has fetched runs via this endpoint in the last week, so might not be fair to just drop the endpoint. |
https://github.com/web-platform-tests/wpt.fyi/tree/master/api#apirun
The endpoint takes two params,
product
andsha
, but they are not guaranteed to uniquely identify a test run (e.g. we have stable and experimental versions for the same product on a given SHA). In this case,/api/run
arbitrarily returns one run that satisfies the filters (I think it's in fact the last created one, which is still "arbitrary" from a user's perspective). We should instead return an error.Furthermore, I think
/api/run
should also take alabels
param. The current approach of takingbrowser[version[os[version]]]
asproduct
may not scale well in the future because of #258 and the possibility that even the full (browser, version, os, version, sha) vector won't be unique enough.The text was updated successfully, but these errors were encountered: